https://github.com/ilya-biryukov commented:
The change makes handling of template names more uniform, which overall looks like a great change. However, we are changing the contract of `QualifiedTemplateName` (it can have a null qualifier now) and this seems both counter-intuitive from the API design perspective and potentially adding bugs in various places where the qualifier is used without checking for null. I am not necessarily saying that's wrong, but maybe we need a different name for the class or a different node for the case where there is no qualifier. We could discuss this in the relevant comment thread. https://github.com/llvm/llvm-project/pull/93433 _______________________________________________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
