I assume Christian Convey was referring to clang-format moving the "//breakpoint here" comments in the tests to different lines.
On Thu, Aug 11, 2016 at 8:15 AM, Zachary Turner via lldb-dev < lldb-dev@lists.llvm.org> wrote: > It's not possible. The problem is that lldb was dependent on order of > includes because each header wasn't properly including what it used. So > when clang-format reordered this, things broke > On Thu, Aug 11, 2016 at 8:04 AM Christian Convey via lldb-dev < > lldb-dev@lists.llvm.org> wrote: > >> Hi Pavel, >> >> Would it make sense to address this problem by fixing clang-format, >> rather than working around it? >> >> (Assuming the clang-format fix is relatively easy, and acceptable to >> clang-format's maintainers.) >> >> - Christian >> >> On Thu, Aug 11, 2016 at 10:41 AM, Pavel Labath via lldb-dev >> <lldb-dev@lists.llvm.org> wrote: >> > I just committed another header cleanup commit, which makes lldb >> > clang-format-immune ( = it still compiles after a full reformat) on >> > linux. Other OS's are still likely to have some missed dependencies. >> > >> > However, when I tried running the test suite I got about 150 failures. >> > Based on a sample of the errors, it looks like the problem is that >> > clang format messes up the "// Place breakpoint here" annotations we >> > use in the tests. >> > Therefore, I propose to apply the clang-format to the lldb source code >> > only as a first step. After that, as a second step, we can go through >> > the tests and fix them up so that the comment markers are where we >> > expect them to be. >> _______________________________________________ >> lldb-dev mailing list >> lldb-dev@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev >> > > _______________________________________________ > lldb-dev mailing list > lldb-dev@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev > >
_______________________________________________ lldb-dev mailing list lldb-dev@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-dev
