================
@@ -154,3 +155,33 @@ MinidumpFile::create(MemoryBufferRef Source) {
   return std::unique_ptr<MinidumpFile>(
       new MinidumpFile(Source, Hdr, *ExpectedStreams, std::move(StreamMap)));
 }
+
+Expected<iterator_range<MinidumpFile::FallibleMemory64Iterator>>
----------------
labath wrote:

Instead of returning another error inside the `Expected<T>`, maybe we could 
reuse the error out parameter -- just set that to whatever we encounter and 
return an empty range?

Something like:
```
ErrorAsOutParameter ErrAsOut(&Err);
Expected<T> ListHeader = ...;
if (!ListHeader) {
  Err = ListHeader.takeError();
  return make_fallible_range(Memory64Iterator::end(), Memory64Iterator::end(), 
Err);
}
```

https://github.com/llvm/llvm-project/pull/101272
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to