================ @@ -494,6 +528,32 @@ Stream::create(const Directory &StreamDesc, const object::MinidumpFile &File) { } return std::make_unique<MemoryListStream>(std::move(Ranges)); } + case StreamKind::Memory64List: { + // Error, unlike expected is true in failure state + Error Err = Error::success(); + // Explicit check on Err so that if we return due to getmemory64list + // getting an error, it's not destructed when unchecked. + if (Err) + return Err; + auto ExpectedList = File.getMemory64List(Err); + if (!ExpectedList) + return ExpectedList.takeError(); ---------------- labath wrote:
This is pretty clumsy, so yeah, I'm going to agree with myself that we should only use a single error object for returning getMemory64List errors. https://github.com/llvm/llvm-project/pull/101272 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits