=?utf-8?q?José?= L. Junior <[email protected]>,taalhaataahir0102
<[email protected]>,taalhaataahir0102
<[email protected]>,taalhaataahir0102
<[email protected]>,taalhaataahir0102 <[email protected]>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/[email protected]>
================
@@ -246,8 +246,8 @@ class Address {
/// \see Address::DumpStyle
bool Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style,
DumpStyle fallback_style = DumpStyleInvalid,
- uint32_t addr_byte_size = UINT32_MAX,
- bool all_ranges = false) const;
+ uint32_t addr_byte_size = UINT32_MAX, bool all_ranges = false,
+ const char *pattern = nullptr) const;
----------------
JDevlieghere wrote:
Why is `pattern` a `const char*` and not a StringRef with an empty string as
the default argument? Or potentially even better an
`std::optional<llvm::Regex>`?
https://github.com/llvm/llvm-project/pull/69422
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
