=?utf-8?q?José?= L. Junior <[email protected]>,taalhaataahir0102
 <[email protected]>,taalhaataahir0102 
<[email protected]>,taalhaataahir0102
 <[email protected]>,taalhaataahir0102 <[email protected]>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/[email protected]>


================
@@ -70,6 +72,31 @@ size_t Stream::PutCString(llvm::StringRef str) {
   return bytes_written;
 }
 
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+                                        const char *pattern) {
+  if (!pattern) {
+    PutCString(text);
+    return;
+  }
+
+  // If pattern is not nullptr, we should use color
----------------
JDevlieghere wrote:

Nit: seems more informative to have the inverse of this comment at the start of 
the function where we have an early return for the trivial case of not having a 
patter to highlight. 

https://github.com/llvm/llvm-project/pull/69422
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to