DavidSpickett marked 2 inline comments as done.
DavidSpickett added a comment.
Thanks for the review, I'll try making the test a bit more flexible so we can
read both registers at once for a bit more coverage.
================
Comment at:
lldb/test/API/linux/aarch64/tls_registers/TestAArch64LinuxTLSRegisters.py:84
+
+ self.check_tls_reg("tpidr2")
+
----------------
omjavaid wrote:
> Should we try to read/write both tpidr and tpidr2 here?
We could but on a system with SME `test_tpidr` will also run. So you're
checking both regardless.
I could change the test program so that it always sets tpidr, but only sets
tpdir2 if told to. Then we could check both here just in case there's an issue
reading one after the other. I'll give that a go.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154930/new/
https://reviews.llvm.org/D154930
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
