omjavaid added inline comments.
================
Comment at:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:279
+ assert(offset < GetTLSSize());
+ src = (uint8_t *)GetTLS() + offset;
} else if (IsSVE(reg)) {
----------------
GetTLS could be GetTLSBuffer similar to GetGPRBuffer/GetFPRBuffer above.
================
Comment at:
lldb/test/API/linux/aarch64/tls_registers/TestAArch64LinuxTLSRegisters.py:73
+
+ @skipUnlessArch("aarch64")
+ @skipUnlessPlatform(["linux"])
----------------
These three tests have a lot of commonalities may be merge them into one
testing the whole logic. Doesn't look like we are getting much out of emitting
three tests from this fairly basic test class.
================
Comment at: lldb/test/API/linux/aarch64/tls_registers/main.c:37
+ case '2':
+ getter = get_tpidr2;
+ setter = set_tpidr2;
----------------
It would be interesting to test reading/writing tpidr2 when SME is not enabled.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154930/new/
https://reviews.llvm.org/D154930
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
