VladimirMakaev added a comment.

I've reached out to Rust wg-debugging for additional feedback 
(https://rust-lang.zulipchat.com/#narrow/stream/317568-t-compiler.2Fwg-debugging/topic/Feedback.20on.20DW_TAG_variant_part.20support.20in.20LLDB)

There a couple of edge cases (when using u128 enums) that not working properly 
so I'm going fix them and add more tests.

Additionally an issue was raised:

> Another comment: Checking the language of the CU might not be reliable 
> because of cross-language inlining. That is, if some Rust code gets inlined 
> into a C++ CU, then the CU will probably still say it is C++ even though it 
> might contain DW_TAG_variant_part DIEs. Just something to be aware of an 
> handle gracefully.

What do you guys think on not gating it behind CU check, maybe there is another 
way? My opinion probably is that there is more risk to CLang users / potential 
conflict with CLang evolution than benefit of having LLDB working for Rust code 
in this niche scenario?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149213/new/

https://reviews.llvm.org/D149213

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to