mib added inline comments.
================ Comment at: lldb/examples/python/crashlog.py:344 + ) + if os.path.exists(source_path): + self.resolved_source = True ---------------- JDevlieghere wrote: > mib wrote: > > I guess that checks that the user have access to the remapped path, is that > > right ? > > > > If that's not the case, I think we should let the user know > Yeah, that's exactly right. We do let the user know by including or emitting > "and sources" in the symbol resolution print. Currently we print the "and > sources" when at least one of the remapped paths is accessible. We could > change this to only print it when all the paths are accessible. We could also > change the message the say "and could not find sources" when a path remapping > is present but the paths are not accessible. It think it would be clearer for the user if we said something like "couldn't access remapped source path (path/to/source)" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152886/new/ https://reviews.llvm.org/D152886 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
