mib added inline comments.
================ Comment at: lldb/examples/python/crashlog.py:340-343 + for key in path_remapping: + source_path = os.path.expanduser( + path_remapping[key] + ) ---------------- ================ Comment at: lldb/examples/python/crashlog.py:344 + ) + if os.path.exists(source_path): + self.resolved_source = True ---------------- I guess that checks that the user have access to the remapped path, is that right ? If that's not the case, I think we should let the user know CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152886/new/ https://reviews.llvm.org/D152886 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits