mib added inline comments.
================
Comment at: lldb/examples/python/crashlog.py:515
def parse_images(self, json_images):
- idx = 0
- for json_image in json_images:
+ for idx, json_image in enumerate(json_images):
img_uuid = uuid.UUID(json_image['uuid'])
----------------
JDevlieghere wrote:
> mib wrote:
> > What do we use `idx` for ?
> You're right, this isn't necessary anymore.
I'm really not a big fan of having very similar image lists ... may be we could
use the from the crashlog object and skip the first entry (since we know it's
the main executable).
What do you think ?
================
Comment at: lldb/examples/python/crashlog.py:555
+ "type": "code",
+ "size": 0x0,
+ "address": frame_offset - location
----------------
Does this needs to be initialized ?
================
Comment at: lldb/examples/python/symbolication.py:400-401
+ })
+ for symbol in self.symbols.values():
+ data['symbols'].append(symbol)
+ with open(tf.name, 'w') as f:
----------------
What about :
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148172/new/
https://reviews.llvm.org/D148172
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
