Fznamznon added inline comments.
================
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:2182-2183
- clang::DumpModuleInfoAction dump_module_info;
- dump_module_info.OutputStream = &result.GetOutputStream().AsRawOstream();
+ std::shared_ptr<llvm::raw_ostream> Out(
+ &result.GetOutputStream().AsRawOstream(), [](llvm::raw_ostream *) {});
+ clang::DumpModuleInfoAction dump_module_info(Out);
----------------
tahonermann wrote:
> Use of `std::shared_ptr` with a deleter that doesn't do anything is unusual;
> I think this deserves a comment.
Sure, done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146412/new/
https://reviews.llvm.org/D146412
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
