aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
This looks much better to me, thank you! LGTM with one small nit for safety.
================
Comment at: clang/include/clang/Frontend/FrontendActions.h:191
+ DumpModuleInfoAction() = default;
+ DumpModuleInfoAction(std::shared_ptr<llvm::raw_ostream> Out)
+ : OutputStream(Out) {}
----------------
A bit of extra safety around implicit conversions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146412/new/
https://reviews.llvm.org/D146412
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
