aprantl added a comment. Herald added a subscriber: JDevlieghere. From an end-user perspective, I like this.
================ Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:9818 + if (ClangASTMetadata *metadata = GetMetadata(fun_decl)) + return metadata->GetObjectPtrLanguage(); + } ---------------- Couple of questions for my understanding: 1. Do you see any opportunities for this to spectacularly do the wrong thing in an ObjectiveC++ program by guessing the wrong language? I suppose this just tries to do a best effort? 2. We're not using the DW_AT_APPLE_runtime_language attribute because it's only attached to Objective-C classes? 3. We're not using the DW_AT_language of the DW_TAG_compile_unit because it won't help us in an ObjC++ program? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145276/new/ https://reviews.llvm.org/D145276 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
