fixathon created this revision.
fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda.
Herald added a project: All.
fixathon requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Current application of bitwise-OR to a binary mask always results in True,
which seems
inconsistent with the intent of the statement, a likely typo.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D131312
Files:
lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
Index: lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
===================================================================
--- lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
+++ lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
@@ -63,7 +63,7 @@
const lldb::addr_t one_cmpl64 = ~((lldb::addr_t)0);
const lldb::addr_t one_cmpl32 = ~((uint32_t)0);
- if ((lbound == one_cmpl64 || one_cmpl32) && ubound == 0) {
+ if ((lbound == one_cmpl64 || lbound == one_cmpl32) && ubound == 0) {
result.Printf("Null bounds on map: pointer value = 0x%" PRIu64 "\n",
value);
} else {
result.Printf(" lbound = 0x%" PRIu64 ",", lbound);
Index: lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
===================================================================
--- lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
+++ lldb/tools/intel-features/intel-mpx/cli-wrapper-mpxtable.cpp
@@ -63,7 +63,7 @@
const lldb::addr_t one_cmpl64 = ~((lldb::addr_t)0);
const lldb::addr_t one_cmpl32 = ~((uint32_t)0);
- if ((lbound == one_cmpl64 || one_cmpl32) && ubound == 0) {
+ if ((lbound == one_cmpl64 || lbound == one_cmpl32) && ubound == 0) {
result.Printf("Null bounds on map: pointer value = 0x%" PRIu64 "\n", value);
} else {
result.Printf(" lbound = 0x%" PRIu64 ",", lbound);
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
