clayborg added a comment. In D126259#3534919 <https://reviews.llvm.org/D126259#3534919>, @jingham wrote:
> In D126259#3534729 <https://reviews.llvm.org/D126259#3534729>, @clayborg > wrote: > >> So the "process handle" command allows us to set signals by signal number as >> well. Does this patch support this? It seems like it wouldn't be too hard to >> do if we wanted to handle this. Lemme know what you think, other than that >> LGTM. > > Ah, I forgot about specifying the signal by number. Before you have a > process I don't think we should allow signals by number. The mapping signal > number -> "signal name for any platform" is not 1-1 so we couldn't guarantee > we were doing the right thing here. I'll put in a check for "specified by > number with no process" and error out. I would add a test for this and make sure it fails gracefully in that case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126259/new/ https://reviews.llvm.org/D126259 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
