labath added a comment.

I'm looking at the SymbolFileOnDemand friendship and the forwarding of 
protected methods (mostly dealing with compile unit lists). Does this by any 
chance have something to do with the fact that there are now two compile unit 
lists (one in the actual symbol file, and one in the wrapping ondemand class? 
Would it be possible to avoid that by making `SymbolFile` a stateless interface 
(just methods, no member variables), and having a putting the member variables 
and other utility functions into a separate class that the real symbol files 
would inherit from? Then only SymbolFileOnDemand would inherit from SymbolFile 
directly, and it would only add the state that it needs (the bool flag, and the 
actual symbol file pointer).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121631/new/

https://reviews.llvm.org/D121631

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to