labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I'm not sure what would be a good way to denote that the new argument
represents the architecture of the host running the debugged process, and not
the one running lldb. This isn't helped by the fact that some of the darwin
platforms use `GetSystemArchitecture` in their implementations (which, afaict,
does mean the lldb host architecture). Having at least a comment would be nice.
================
Comment at: lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp:134
if (m_remote_platform_sp)
return m_remote_platform_sp->GetSupportedArchitectures();
return m_supported_architectures;
----------------
I'm not sure the default argument value is that useful.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121484/new/
https://reviews.llvm.org/D121484
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
