[Lldb-commits] [PATCH] D120948: Disable LLDB index cache for .o files with no UUID.

[jeffrey tan via Phabricator via lldb-commits]

yinghuitan added inline comments.


================
Comment at: lldb/include/lldb/Core/DataFileCache.h:130-138
+  bool operator==(const CacheSignature &rhs) const {
     if (m_uuid != rhs.m_uuid)
-      return true;
+      return false;
     if (m_mod_time != rhs.m_mod_time)
-      return true;
+      return false;
     if (m_obj_mod_time != rhs.m_obj_mod_time)
+      return false;
----------------
Nit: I believe this can be simplified as:
```
return m_uuid == rhs.m_uuid && m_mod_time == rhs.m_mod_time && m_obj_mod_time 
== rhs.m_obj_mod_time;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120948/new/

https://reviews.llvm.org/D120948

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits