yinghuitan accepted this revision.
yinghuitan added inline comments.
This revision is now accepted and ready to land.
================
Comment at: lldb/include/lldb/Core/DataFileCache.h:127
+ /// unique idenifier like the UUID being valid.
+ bool IsValid() const { return m_uuid.hasValue(); }
----------------
Do we plan to ship with this design (no caching for module .o file without
uuid)? If so, I wonder if we should emit reason information for module not
loaded from cache (like signature mismatch/changed vs uuid unavailable)?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120948/new/
https://reviews.llvm.org/D120948
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
