labath accepted this revision.
labath added a comment.

In D117707#3270072 <https://reviews.llvm.org/D117707#3270072>, @jingham wrote:

>> I am a bit curious about the `__lldb` prefix. I'm wondering if there's a way 
>> to avoid having it, while still maintaining isolation from any type with the 
>> same name coming from the debug info. I'm thinking about putting it in some 
>> kind of an anonymous namespace or something... Does anyone know if that 
>> works?
>
> This will be the actual type of an SBValue, as is the case in other instances 
> where we've made up types, so users will see this type if they look closely.  
> So it should be clear from the name that this is just an artificial type lldb 
> made up.  `__lldb_whatever` expresses that pretty clearly, but I'm worried 
> some reasonable looking name in an anonymous namespace would send users off 
> on a wild goose chase.

Yeah, that makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117707/new/

https://reviews.llvm.org/D117707

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to