Indeed not.  Since you can get everything you would need straightforwardly 
using SBFrame::FindVariables, there’s no pressing need to give another way to 
do it using HandleCommand.

Jim

> On Jan 11, 2022, at 2:02 PM, Dave Lee via Phabricator 
> <revi...@reviews.llvm.org> wrote:
> 
> kastiglione added a comment.
> 
>> if I run “frame var” from HandleCommand in a script, with this change I 
>> can’t rely on the command status to tell whether the command output had 
>> anything interesting in it. That seems awkward.
> 
> This could be resolved by introducing a new enum value to indicate partial 
> success, partial failure. I think that would be reasonable. I don't think 
> that should block this change though, do you?
> 
> 
> Repository:
>  rG LLVM Github Monorepo
> 
> CHANGES SINCE LAST ACTION
>  https://reviews.llvm.org/D116788/new/
> 
> https://reviews.llvm.org/D116788
> 

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to