clayborg added a comment.

I would vote that if any argument or option is specified, and results in 
something not being found, that an error be returned. The error state doesn't 
do anything for the user on the command line, but it is nice to know that 
something failed to produce a result due to arguments being given. Any tests 
that are failing now when they didn't before can be modified.

Slo the cases I can think of are:

- "frame variable" with no args that results in no variables being displayed 
because there is no debug info returns an error like "no debug information for 
current stack frame"
- "frame variable" with no args that results in no variables being displayed 
and there is debug info, returns an error like "no variables found in debug 
information"
- "frame variable" with any args or options that do not find a match returns an 
error with possible multiple strings like "no variables found that match the 
name '%s'" (for a argument) or "no variables found that matches the regular 
expression '%s'" (for options)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116788/new/

https://reviews.llvm.org/D116788

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to