clayborg added a comment.

In D115073#3174376 <https://reviews.llvm.org/D115073#3174376>, @labath wrote:

> I don't think we actually disagree here. I'm aware of your use case (let's 
> call it "dynamic mode") for appending to a buffer. I agree it's useful and I 
> don't want to change that. What I want to remove is the other mode 
> (non-dynamic). Presently, this is the only mode, but we're not actually 
> making a good use of it. All of the existing use cases can be implemented 
> with a "dynamic" buffer. And the code would be much simpler since there is 
> only one mode to support -- one in which the data encoder owns the buffer it 
> is writing to and can resize it at will.

Ahh! Gotcha. That I can do. Thanks for the feedback, I will post an update 
shortly!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115073/new/

https://reviews.llvm.org/D115073

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to