clayborg added inline comments.

================
Comment at: lldb/source/Expression/DWARFExpression.cpp:465
       std::unique_ptr<DataBufferHeap> head_data_up(
           new DataBufferHeap(m_data.GetDataStart(), m_data.GetByteSize()));
 
----------------
That would crash the program. The data here is coming from the DWARF from a 
mmap'ed read only file. We can't modify the data, and thus this is why we make 
a copy in the first place: so we can modify the DWARF data and fixup the 
address info.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115073/new/

https://reviews.llvm.org/D115073

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to