labath added inline comments.
================
Comment at:
lldb/source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:388-392
for (llvm::StringRef line : lines(Record::Func)) {
if (auto record = FuncRecord::parse(line))
add_symbol(record->Address, record->Size, record->Name);
}
----------------
Can you check if we can remove this now?
I originally thought that we can remove this entire function, but I forgot
about PUBLIC records -- we don't have functions or compile units for those, so
they will have to stay.
================
Comment at: lldb/test/Shell/SymbolFile/Breakpad/line-table.test:45
# CHECK-LABEL: breakpoint set -f c.c -l 2
-# CHECK: Breakpoint 1: where = line-table.out`func + 2, address =
0x00000000004000b2
+# CHECK: Breakpoint 1: where = line-table.out`func + 2 at c.c:2, address =
0x00000000004000b2
----------------
We should have a more explicit test for this. Some interesting things to check
might be
- "image lookup -v" command should have a new `Function` entry in its output
- "image dump symfile" should contain some output about the functions that have
been parsed
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113163/new/
https://reviews.llvm.org/D113163
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
