jingham added a comment. In D110298#3026579 <https://reviews.llvm.org/D110298#3026579>, @clayborg wrote:
> The changes look fine from a quick read. See inline comments The command add/command delete situation is a little fractured. We currently have: command alias/command unalias - Handles aliases to commands command regex/command delete - Adds and deletes regex commands command script add/command script delete It would be weird for "command delete" to delete regex and multiword commands but not script commands and not aliases. We could centralize everything to "command add --multiword". Then it would make sense to delete everything in command delete as well. But that might break a bunch of people's .lldbinit's etc. And anyway, I don't have time to do all that right now. Moreover, I actually think that deleting a multiword command as a separate gesture isn't a bad idea. Deleting a script command deletes one thing and can be easily undone (by re-adding that one command). Deleting a multiword command can potentially wipe out a whole hierarchy that you had built up. It would be really annoying to have: (lldb) command delete foo bar where I forgot to put "baz" on the end would delete baz and everything else in the container. You could add --force to delete, but I'm not sure that's a better interface. If somebody can think of a more apt name than "multiword" I'm not wedded to that name. "container" might be okay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110298/new/ https://reviews.llvm.org/D110298 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
