[Lldb-commits] [PATCH] D109928: [lldb] Remove IRExecutionUnit::CollectFallbackNames

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added a comment.

I think this looks fine, just verify that this in a C++ case an expression with 
an `extern "C"` function call works fine e.g.

  extern "C" {
    int g() { return 10;}
  }
  
  int main() {
     return g();  // break here and run expr g()
  }

I discovered the other day that we mangle `extern "C"` functions in C++ mode 
and I have a fix I wanted to run by everyone but I have not had a chance to do 
it yet.

So this case get resolved in `CollectFallbackNames(...)`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109928/new/

https://reviews.llvm.org/D109928

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits