labath added a comment. In D96202#2551546 <https://reviews.llvm.org/D96202#2551546>, @JDevlieghere wrote:
> In D96202#2550712 <https://reviews.llvm.org/D96202#2550712>, @labath wrote: > >> What exactly is that use case? Do you want to run the tests with the >> debugserver that comes with that xcode install? If that's the case, then I >> would expect this to just work, as lldb knows that in a framework build, the >> "support executable directory" is located inside the framework: >> https://github.com/llvm/llvm-project/blob/main/lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm#L138 > > Even better, that's exactly the logic I had in mind, but I was going to add > it in dotest based on the `--framework` argument. Cool, cool, cool. Cool, I'm glad that this works out. ================ Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py:75-79 - if "LLDB_DEBUGSERVER_PATH" in os.environ: - return os.environ["LLDB_DEBUGSERVER_PATH"] - return _get_debug_monitor_from_lldb( - lldbtest_config.lldbExec, "lldb-server") ---------------- rupprecht wrote: > labath wrote: > > @rupprecht : I'm adding you mainly because my last attempt to change this > > function broke some google integration stuff. > Thanks, patching this in now! (Sorry for the delay, I was out a couple days) Sure, np. Let me know how it works out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96202/new/ https://reviews.llvm.org/D96202 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
