JDevlieghere added a comment. In D96202#2550712 <https://reviews.llvm.org/D96202#2550712>, @labath wrote:
> In D96202#2549497 <https://reviews.llvm.org/D96202#2549497>, @JDevlieghere > wrote: > >> This will break my "run the tests against an Xcode install", but it seems >> like I should be able to work around that looking for debugserver in the >> LLDB.framework in `get_debugserver_exe`. Overall this is a pretty nice >> cleanup so seems like a fair trade-off. LGTM. > > What exactly is that use case? Do you want to run the tests with the > debugserver that comes with that xcode install? If that's the case, then I > would expect this to just work, as lldb knows that in a framework build, the > "support executable directory" is located inside the framework: > https://github.com/llvm/llvm-project/blob/main/lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm#L138 Even better, that's exactly the logic I had in mind, but I was going to add it in dotest based on the `--framework` argument. Cool, cool, cool. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96202/new/ https://reviews.llvm.org/D96202 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
