labath added a comment.

I think that streamlining the packet (de)serialization process is badly 
needing. I'm not so sure about the approach though. On one hand, it's 
definitely an improvement. On the other, it does not handle the deserialization 
process, and I was hoping we could have a solution which handles both, for two 
reasons:

- it makes things simpler
- it allows us to avoid the need for tests which explicitly test serialization 
and deserialization of each packet, as the things is implemented (and tested) 
once, centrally.

Have you looked at the how llvm YAML and JSON libraries handle 
(de)serialization? I was hoping that we could implement something similar to 
that...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93225/new/

https://reviews.llvm.org/D93225

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to