DavidSpickett added reviewers: labath, jasonmolenda. DavidSpickett added a comment.
I realise it's a lot to review but if you have any initial comments on the usability that'd be great. My main point here was to make the if-else chain a bit "safer" and more easily extended. The parsing logic itself I did not change, to keep things clear (though I would like to improve it later). I've also put up https://reviews.llvm.org/D93226 where you can see how it changes qProcessInfo parsing. There are a few more packets that could benefit to varying degrees. (some are just 1/2 keys) - qGDBServerVersion - qMemoryRegionInfo - qWatchpointSupportInfo - qProcessInfo again (in GetCurrentProcessInfo) - qLaunchGDBServer - qModuleInfo A quick look over them doesn't show anything that would prevent KeyValueExtractorGDBRemote from applying there too if it proves useful here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93225/new/ https://reviews.llvm.org/D93225 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
