labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
In D91241#2422571 <https://reviews.llvm.org/D91241#2422571>, @omjavaid wrote: > In D91241#2422517 <https://reviews.llvm.org/D91241#2422517>, @labath wrote: > >> Yes, but there's no reason that this _must_ be done in AddRegister, is there? >> >> You could just build a local map directly inside the finalize function, >> right? > > Yes this just avoid an extra iteration over m_regs list. This is much better. The iteration doesn't cost much (if anything), but the member variable increases size of the object permentently. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91241/new/ https://reviews.llvm.org/D91241 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
