labath added a comment. Looks great. One question about the member variable...
================ Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.h:90 dynamic_reg_size_map m_dynamic_reg_size_map; + reg_to_reg_map m_remote_to_local_regnum_map; size_t m_reg_data_byte_size = 0u; // The number of bytes required to store ---------------- If, I understand correctly, this is only used inside the Finalize function? Could this be a local variable instead of a member? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91241/new/ https://reviews.llvm.org/D91241 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
