mgorny added a comment.

In D91810#2407461 <https://reviews.llvm.org/D91810#2407461>, @labath wrote:

> I think that the real fix here would be to change the plugin selection logic 
> (Target::CreateProcess) to convey the fact that we're looking for a 
> connectable plugin. The method already contains a `FileSpec *core_file` 
> argument, which I guess is needed to select the proper core file subclass, so 
> adding a can_connect argument would not be unreasonable (though not exactly 
> pretty either).

Would maybe a static class variable ('property'?) be cleaner?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91810/new/

https://reviews.llvm.org/D91810

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to