labath added a comment.

This is all weird (not in a "your fault"  way). ProcessFreeBSD is decidedly a 
local-only plugin. It could never successfully complete the "process connect" 
command, regardless of whether we have some other remote plugin or not.

I think that the real fix here would be to change the plugin selection logic 
(Target::CreateProcess) to convey the fact that we're looking for a connectable 
plugin. The method already contains a `FileSpec *core_file` argument, which I 
guess is needed to select the proper core file subclass, so adding a 
can_connect argument would not be unreasonable (though not exactly pretty 
either).

Though, for the purposes of this test, just adding a "--plugin gdb-remote" 
argument to the "process connect" command should be sufficient as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91810/new/

https://reviews.llvm.org/D91810

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to