mgorny added a comment. In D90757#2374533 <https://reviews.llvm.org/D90757#2374533>, @emaste wrote:
> When running locally with this change applied I get: > > ******************** > Failed Tests (8): > lldb-api :: > commands/expression/multiline-completion/TestMultilineCompletion.py > lldb-api :: > functionalities/breakpoint/breakpoint_set_restart/TestBreakpointSetRestart.py These two pass reliably for me. You can check if it could be related to parallel testing. To start them individually: ninja check-lldb-api-commands-expression-multiline-completion ninja check-lldb-api-functionalities-breakpoint-breakpoint_set_restart > lldb-api :: > functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointThreads.py This one's unstable. > lldb-api :: iohandler/completion/TestIOHandlerCompletion.py > lldb-api :: python_api/watchpoint/watchlocation/TestSetWatchlocation.py > lldb-api :: python_api/watchpoint/watchlocation/TestTargetWatchAddress.py All three pass for me reliably right now but I recall that watchlocation test could be fragile to parallel runs. > lldb-api :: tools/lldb-server/thread-name/TestGdbRemoteThreadName.py This one I've commented out for testing per earlier comments here and forget to revert. > lldb-unit :: > tools/lldb-server/tests/./LLDBServerTests/StandardStartupTest.TestStopReplyContainsThreadPcs This one I know about. There's no easy way to xfail an unittest, and the hack to skip it is kinda ugly, so I kept it for now not to forget about it. > ******************** > Unexpectedly Passed Tests (2): > lldb-api :: api/multiple-debuggers/TestMultipleDebuggers.py I think this one's unstable in long runs. I recall I marked it xfail first but then removed the xfail because it succeeded. But then, it failed in a few consecutive, so I've xfailed it ;-). > lldb-api :: lang/c/conflicting-symbol/TestConflictingSymbol.py This one also reliably XFAILs for me. > Testing Time: 367.34s > Unsupported : 422 > Passed : 1741 > Expectedly Failed : 5 > Failed : 8 > Unexpectedly Passed: 2 What do you suggest? Is it fine to go with my results for as long as I work on it? I can update it to match CI/buildbot results later. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90757/new/ https://reviews.llvm.org/D90757 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
