JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM with the few nits addressed.
================
Comment at: lldb/include/lldb/Symbol/Type.h:269
+ lldb::ModuleSP GetModule();
+
----------------
================
Comment at: lldb/test/API/functionalities/type_get_module/Makefile:1
+
+C_SOURCES := main.c compile_unit1.c compile_unit2.c
----------------
spurious newline?
================
Comment at: lldb/test/API/functionalities/type_get_module/compile_unit1.c:1
+
+struct compile_unit1_type {
----------------
spurious newline?
================
Comment at: lldb/test/API/functionalities/type_get_module/compile_unit2.c:1
+
+struct compile_unit2_type {
----------------
spurious newline?
================
Comment at: lldb/test/API/functionalities/type_get_module/main.c:1
+
+int main() { return 0; }
----------------
spurious newline?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88483/new/
https://reviews.llvm.org/D88483
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
