mib requested changes to this revision. mib added a comment. This revision now requires changes to proceed.
Could please follow PEP8 style guide regarding variable names <https://www.python.org/dev/peps/pep-0008/#function-and-variable-names> : Function names should be lowercase, with words separated by underscores as necessary to improve readability. Variable names follow the same convention as function names. I also left some inline suggestions regarding the test. After changing that, it should be good for me. Thanks in advance. ================ Comment at: lldb/test/API/functionalities/type_get_module/TestTypeGetModule.py:36 + type1 = target.FindFirstType(type1Name) + self.assertTrue(type1.IsValid() == True) + ---------------- ================ Comment at: lldb/test/API/functionalities/type_get_module/TestTypeGetModule.py:39 + type2 = target.FindFirstType(type2Name) + self.assertTrue(type2.IsValid() == True) + ---------------- ================ Comment at: lldb/test/API/functionalities/type_get_module/TestTypeGetModule.py:41-46 + type1Module = type1.GetModule() + type2Module = type2.GetModule() + + result = \ + (exeModule == type1Module) and (exeModule == type2Module) + self.assertTrue(result == True) ---------------- CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
