jasonmolenda added inline comments.
================
Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:6223
+ range_info.GetDirtyPageList();
+ if (dirty_page_list.hasValue()) {
+ for (addr_t dirtypage : dirty_page_list.getValue()) {
----------------
jasonmolenda wrote:
> clayborg wrote:
> > If we add a bool argument, we might need to return an error if the
> > lldb-server doesn't support the dirty page list stuff. Some regions won't
> > have dirty pages, but we might need add detection for any dirty pages and
> > then error out at the end if user requested a minimal core file
> in the qMemoryRegionInfo packet response, a remote stub that can identify
> dirty pages should include a dirty-pages: key-value entry in every response
> where they're supported, even if it's an empty list. I clarified this in the
> docs. That's how we'll detect the difference between "no dirty pages" and
> "dirty pages not supported".
Oh, and once we're inside lldb, I have the dirty page list returned as an
Optional vector. For a memory region where we don't have any dirty page
information, there's no vector. For a memory region where we have dirty page
information -- and there are no pages, an empty vector is returned.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88387/new/
https://reviews.llvm.org/D88387
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
