clayborg added a comment. In D86670#2244092 <https://reviews.llvm.org/D86670#2244092>, @labath wrote:
> I think it would be appropriate to discuss the design of this feature on > lldb-dev before going over the individual patches. One of the fundamental > aspects of this patchset that I think should not be overlooked is that it > essentially adds a new level of structure ( a "Target Group") lldb. One of > the questions I'd have is whether this concept shouldn't be formalized > somewhere instead of it existing just virtually as the group of threads that > happen to share the same trace object. The idea was to iterate on the design of the trace feature using these patches and have the discussion here. The idea is one trace file can create N individual targets. Each target can be independent and the threads contained in each belong to each target. "trace dump" when no args are supplied it could maybe only dump the currently selected target to start with? I am not sure what the right semantics are, but that shouldn't stop us with proceeding with these patches IMHO. It will be easy to modify as we evolve if we do want to have target groups, but I don't think it is required for these patches. The target group is a much higher level design that can affect many things and could be used in this case, but isn't required. If a trace plug-in needs to iterate over all of the targets this can be achieved by using the debugger to grab all targets and iterate over them, so no real group is required. So it would simplify things right now if we say that "trace dump" dumps the trace data for the currently selected target right now. That will map well with the stepping commands that will soon be added to allow forward and reverse traversal of the trace data. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86670/new/ https://reviews.llvm.org/D86670 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
