wallace added inline comments.
================ Comment at: lldb/include/lldb/Target/Target.h:1105 + void SetTrace(const lldb::TraceSP &trace_sp); + ---------------- JDevlieghere wrote: > Who owns the trace? If there's a 1:1 relationship between a trace and a > target, can we make the target its owner? I'm trying to avoid adding shared > pointers if possible. Well, there's a 1 to many relationship. Many targets can own the same trace object, as a single trace can have data of several processes. On the other hand, there should no other object that could own a trace. I haven't found a better solution :( ================ Comment at: lldb/include/lldb/Target/Target.h:1341 unsigned m_next_persistent_variable_index = 0; + lldb::TraceSP m_trace; /// Stores the frame recognizers of this target. ---------------- JDevlieghere wrote: > Doxygen comment? good catch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86670/new/ https://reviews.llvm.org/D86670 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
