jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
Okay, LGTM. I don't mind either way, and I suspect with the offset field
becoming optional soon, it's unlikely to appear frequently, so the verbosity is
a non-issue then.
================
Comment at: lldb/unittests/SymbolFile/DWARF/XcodeSDKModuleTests.cpp:53
+ DebugAbbrevOffset: 0
+ AddressSize: 8
Entries:
----------------
Nit: the value here is misaligned.
================
Comment at: llvm/unittests/DebugInfo/GSYM/GSYMTest.cpp:2296
StringRef yamldata = R"(
----------------
Could you fix this linter nit, whilst you're here, please?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85289/new/
https://reviews.llvm.org/D85289
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
