labath added a comment.

Sorry about the delay, I was OOO.

I think that making these consistent with the DWARF spec is a good idea. It's 
true that this makes `DebugAbbrevOffset` a bit longish. I could also live with 
just `AbbrevOffset`, but I think the longer version is also fine for two 
reasons:

- I expect most of this stuff to be created by copy-pasting
- Ideally, I would want to avoid explicitly specifying this field in most 
cases, and instead rely on some sort of symbolic references between the 
sections (as discussed in the other reviews)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85289/new/

https://reviews.llvm.org/D85289

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to