labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
In D84815#2203802 <https://reviews.llvm.org/D84815#2203802>, @amccarth wrote: > I tried but failed to make a negative test. LLDB sends the errors message to > stderr when the `target modules dump symfile` command fails. I tried using > redirects to combine stdout and stderr, but lit's built-in shell told me that > was unsupported. I couldn't find a good way to arrange FileCheck to confirm > the absence case. We have a bunch of lldb tests that do `%lldb ... 2>&1 | FileCheck` and they don't seem to be disabled on windows. What makes this test special? LGTM, because I don't think a negative test is strictly required for this, though it would definitely be nice to have. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84815/new/ https://reviews.llvm.org/D84815 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
