logan-5 added a comment.

In D84126#2165585 <https://reviews.llvm.org/D84126#2165585>, @nemanjai wrote:

> There is a lot of instances where this warning fires in the unit tests since 
> gtest does not appear to use the `override` keyword. This in turn causes 
> failures on bootstrap builds that use `-Werror`.
>  An example: 
> http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/10717
>
> Can we either get this pulled until the failures in bootstrap are fixed or 
> quickly fix the code that causes the failures?


I've got fixes for these failures waiting on review 
(https://reviews.llvm.org/D84244). Perhaps I'll go ahead and commit them now, 
then revert them and fix it differently if the reviewers request it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84126/new/

https://reviews.llvm.org/D84126



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to