erichkeane added a comment.

Ive got a bit a of a problem here: This flag (suggest-override) on GCC 8.3 (and 
others) warns on missing-override EVEN WHEN the function is marked 'final'.  
This was not fixed until GCC 9.2: https://godbolt.org/z/55KeM3

The result is my build gave a few thousand diagnostics for this.  I'd suggest 
disabling this unless the GCC version is >9.1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84126/new/

https://reviews.llvm.org/D84126



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to