teemperor added a comment. In D80543#2054405 <https://reviews.llvm.org/D80543#2054405>, @labath wrote:
> I am all for this, because makes lldb code more consistent with llvm (llvm > used to have a LLVM_DELETED_FUNCTION macro, but it was removed as soon as > c++11 came into being). > > But please don't commit this straight away -- let's wait a couple of days to > give people a chance to comment on things. Wasn't LLVM_DELETED_FUNCTION not just a compatibility thing with certain MSVC versions that didn't handle `= delete` correctly? DISALLOW_COPY_AND_ASSIGN seems to be more about preventing copy-pasted declarations. I'm not sure if I see the motivation for this change, but I also don't really see a problem if we remove this to get rid of another LLDB_* macro. So IMHO this is change is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80543/new/ https://reviews.llvm.org/D80543 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
