JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.
================
Comment at:
lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:46
+ m_lua(std::make_unique<Lua>()) {
+ llvm::cantFail(GetLua().EnterSession(debugger.GetID()));
+}
----------------
labath wrote:
> I don't think this is right. You should be able to set `lldb.debugger` once
> and for all during initialization, but the rest of the variables (thread,
> process, target) still need to be set upon entering the lua script as these
> can vary during the lifetime of an Debugger.
I prefer setting/unsetting them together. This also ensures you don't have
access to `lldb.debugger` outside of an interactive session.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71801/new/
https://reviews.llvm.org/D71801
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
